Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

Masaru Nomura
2014-05-18T19:12:39Z

>> - memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags etc */
>> + memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */
>
> It looks like this memset is unnecessary
> as it's already zeroed by LIBCFS_ALLOC->
> LIBCFS_ALLOC_GFP->LIBCFS_ALLOC_POST->memset.
>
> It seems as if all these ALLOC macros could
> use quite a bit of cleaning/sorting out.

Thank you for pointing it out. I didn't know that nor check the macros.
I'll care about similar problems next time.

I checked the macros and kind of understand what you mean,
but honestly I'm not sure whether or not it's perfectly correct to
remove memset.

If this is the right way, I think we can remove the following memset
which I modified as well.
The reason is the same as you mentioned. conn is zeroed by
LIBCFS_ALLOC before memset.

[PATCH 1/5]
@@ -1041,26 +1041,26 @@ ksocknal_create_conn (lnet_ni_t *ni,
ksock_route_t *route,
goto failed_0;
}

- memset (conn, 0, sizeof (*conn));
+ memset(conn, 0, sizeof(*conn));

Thank you,
Masaru