public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: phy: msm: fix bug in probe()
Date: Tue, 20 May 2014 07:19:12 +0000	[thread overview]
Message-ID: <1400570352.1464.89.camel@iivanov-dev> (raw)
In-Reply-To: <20140519203519.GB5671@mwanda>

On Mon, 2014-05-19 at 23:35 +0300, Dan Carpenter wrote:
> My previous patch introduced a bug which prevented this driver from
> loading.  devm_ioremap_resource() has a call to
> devm_request_mem_region() which will fail because the address space is
> shared between this PHY driver and CI device controller driver.
> 
> Fixes: 10f0577aa5cb ('usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()')
> Reported-by:"Ivan T. Ivanov" <iivanov@mm-sol.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index 4f88174..ced34f3 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1586,9 +1586,11 @@ static int msm_otg_probe(struct platform_device *pdev)
>  				      np ? "alt_core" : "usb_hs_core_clk");
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	motg->regs = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(motg->regs))
> -		return PTR_ERR(motg->regs);
> +	if (!res)
> +		return -EINVAL;
> +	motg->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
> +	if (!motg->regs)
> +		return -ENOMEM;

Well, I don't think that your previous patch was merged anywhere.
Or I am missing something? So you have to just made v3 of your
original patch.

Regards,
Ivan


  reply	other threads:[~2014-05-20  7:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 20:35 [patch] usb: phy: msm: fix bug in probe() Dan Carpenter
2014-05-20  7:19 ` Ivan T. Ivanov [this message]
2014-05-20  8:25 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400570352.1464.89.camel@iivanov-dev \
    --to=iivanov@mm-sol.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox