From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Taine Date: Wed, 28 May 2014 15:14:06 +0000 Subject: [PATCH 1/2] ALSA: au1x00: Use resource_size instead of computation Message-Id: <1401290047-30005-2-git-send-email-benoit.taine@lip6.fr> List-Id: References: <1401290047-30005-1-git-send-email-benoit.taine@lip6.fr> In-Reply-To: <1401290047-30005-1-git-send-email-benoit.taine@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jaroslav Kysela Cc: benoit.taine@lip6.fr, Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/resource_size.cocci Signed-off-by: Benoit Taine --- Not compile tested, due incompatible architecture. sound/mips/au1x00.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c index d10ef76..fbcaa54 100644 --- a/sound/mips/au1x00.c +++ b/sound/mips/au1x00.c @@ -648,14 +648,14 @@ static int au1000_ac97_probe(struct platform_device *pdev) goto out; err = -EBUSY; - au1000->ac97_res_port = request_mem_region(r->start, - r->end - r->start + 1, pdev->name); + au1000->ac97_res_port = request_mem_region(r->start, resource_size(r), + pdev->name); if (!au1000->ac97_res_port) { snd_printk(KERN_ERR "ALSA AC97: can't grab AC97 port\n"); goto out; } - io = ioremap(r->start, r->end - r->start + 1); + io = ioremap(r->start, resource_size(r)); if (!io) goto out;