[patch] mfd: vexpress: use after free in vexpress_syscfg_regmap_init()

Dan Carpenter
2014-06-11T06:07:25Z

We should return NULL if regmap_init() fails instead of continuing.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c
index 73068e5..2c0ddb2 100644
--- a/drivers/misc/vexpress-syscfg.c
+++ b/drivers/misc/vexpress-syscfg.c
@@ -231,10 +231,12 @@ static struct regmap *vexpress_syscfg_regmap_init(struct device *dev,
func->regmap = regmap_init(dev, NULL, func,
&vexpress_syscfg_regmap_config);

- if (IS_ERR(func->regmap))
+ if (IS_ERR(func->regmap)) {
kfree(func);
- else
- list_add(&func->list, &syscfg->funcs);
+ return NULL;
+ }
+
+ list_add(&func->list, &syscfg->funcs);

return func->regmap;
}