From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 01 Sep 2014 16:55:06 +0000 Subject: [PATCH - resend] checkpatch: Remove unnecessary + after {8,8} Message-Id: <1409590506.2614.4.camel@joe-AO725> List-Id: References: <1405128087.6751.12.camel@joe-AO725> <20140712013927.GA30781@kroah.com> <1405129612.6751.24.camel@joe-AO725> <20140712020114.GA12301@kroah.com> <20140712020520.GA18611@kroah.com> In-Reply-To: <20140712020520.GA18611@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernelnewbies@lists.kernelnewbies.org There's a useless "+" use that needs to be removed as perl 5.20 emits a "Useless use of greediness modifier '+'" message each time it's hit. Reported-by: Greg KH Signed-off-by: Joe Perches --- Resending, maybe Andrew's all-seeing eye blinked... On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote: > Ok, with linux-next I get the same thing: Thanks Greg. scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d5ac001..370a974 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2376,7 +2376,7 @@ sub process { "please, no space before tabs\n" . $herevet) && $fix) { while ($fixed[$fixlinenr] =~ - s/(^\+.*) {8,8}+\t/$1\t\t/) {} + s/(^\+.*) {8,8}\t/$1\t\t/) {} while ($fixed[$fixlinenr] =~ s/(^\+.*) +\t/$1\t/) {} }