From: Firo Yang <firogm@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] firmware: Fix memory leak in error path
Date: Fri, 05 Jun 2015 16:38:36 +0000 [thread overview]
Message-ID: <1433522316-23063-1-git-send-email-firogm@gmail.com> (raw)
In error path, we forgot to free fw_work alloced by kzalloc.
This will make a memory leak. So just free it before return.
Signed-off-by: Firo Yang <firogm@gmail.com>
---
drivers/base/firmware_class.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 8c3aa3c..9c42883 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1307,8 +1307,10 @@ request_firmware_nowait(
fw_work->module = module;
fw_work->name = kstrdup_const(name, gfp);
- if (!fw_work->name)
+ if (!fw_work->name) {
+ kfree(fw_work);
return -ENOMEM;
+ }
fw_work->device = device;
fw_work->context = context;
fw_work->cont = cont;
--
2.4.2
next reply other threads:[~2015-06-05 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 16:38 Firo Yang [this message]
2015-06-05 16:43 ` [PATCH] firmware: Fix memory leak in error path Julia Lawall
2015-06-06 3:13 ` Firo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433522316-23063-1-git-send-email-firogm@gmail.com \
--to=firogm@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox