From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Date: Fri, 04 Sep 2015 16:43:38 +0000
Subject: Re: [PATCH] coccinelle: misc: move constants to the right
Message-Id: <1441385018.9666.51.camel@perches.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1441382154-16840-1-git-send-email-Julia.Lawall@lip6.fr>
In-Reply-To: <1441382154-16840-1-git-send-email-Julia.Lawall@lip6.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: cocci@systeme.lip6.fr

On Fri, 2015-09-04 at 17:55 +0200, Julia Lawall wrote:
> Move constants to the right in binary operators.

Thanks Julia.

I think this should be sent to lkml.

Does this manage to not move upper case identifiers
that aren't constants?

{
	int E = foo();

	if (E < bar())
		baz();
}

> diff --git a/var/julia/linuxcopy/scripts/coccinelle/misc/compare_const_fl.cocci b/var/julia/linuxcopy/scripts/coccinelle/misc/compare_const_fl.cocci
[]
> +++ b/scripts/coccinelle/misc/compare_const_fl.cocci
> @@ -0,0 +1,171 @@
> +/// Move constants to the right of binary operators.
> +//# Depends on personal taste in some cases.
> +///
> +// Confidence: Moderate

If not, maybe some of the cases that don't work
well should be noted in the commit message and
perhaps here in the code comments as well.