Re: [PATCH v2] powerpc/mpc5xxx: Avoid dereferencing potentially freed memory

Michael Ellerman
2015-10-19T04:38:10Z

On Fri, 2015-10-16 at 22:05 +0200, Christophe JAILLET wrote:
> Hi,
> sorry if un-clear.
>
> What I mean is that in the patch related
> 'powerpc/sysdev/mpc5xxx_clocks.c', there was no call to 'be32_to_cpup'.
> So in the proposed patch, 'of_property_read_u32' adds it.
>
> While in the patch against 'powerpc/kernel/prom.c', 'be32_to_cpup' was
> called explicitly.
> So using 'of_property_read_u32' keep the same logic.

Ah right, I understand now.

> Basically the code from 'mpc5xxx_clocks.c' and from 'prom.c' were
> written the same way. I found spurious that a call to 'be32_to_cpup' was
> done in only one case.
> Maybe, it was a missing in 'mpc5xxx_clocks.c'.

Yes it was missing in that code.

But that's not a real bug because that code only ever runs on BE systems.

cheers