From: Joe Perches <joe@perches.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: fix naked sscanf false positives
Date: Sat, 06 Feb 2016 23:08:50 +0000 [thread overview]
Message-ID: <1454800130.21293.6.camel@perches.com> (raw)
In-Reply-To: <20160205082952.GA18361@kwern-VirtualBox>
On Sat, 2016-02-06 at 13:24 -0800, Kevin Wern wrote:
> On Sat, Feb 6, 2016 at 9:20 AM, Joe Perches <joe@perches.com> wrote:
> >
> > It's a single line sscanf vs multi-line sscanf issue
> >
> > $line works on
> > ret = sscanf(buf, &foo, &bar);
> >
> > $stat works on that and
> > ret = sscanf(buf,
> > &foo,
> > &bar);
> >
>
> Ah, ok. I dont think having just the ending paren will work though
> because the
> paren can be on the next line, so the pre-patch statement is most
> correct.
> What we should do, then, is something like:
Not really.
That'd only find an additional
sscanf
(buf,
foo,
bar);
And that's quite unlikely.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-06 23:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 8:29 [PATCH] checkpatch.pl: fix naked sscanf false positives Kevin Wern
2016-02-05 9:46 ` Dan Carpenter
2016-02-06 5:26 ` Joe Perches
2016-02-06 6:58 ` Kevin Wern
2016-02-06 17:20 ` Joe Perches
2016-02-06 21:24 ` Kevin Wern
2016-02-06 23:08 ` Joe Perches [this message]
2016-02-12 5:35 ` Kevin Wern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454800130.21293.6.camel@perches.com \
--to=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox