From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Fri, 25 Mar 2016 05:56:06 +0000 Subject: Re: [PATCH 1/2] staging: dgnc: fix 'line over 80 characters' Message-Id: <1458885366.29362.1.camel@perches.com> List-Id: References: <20160325024406.GA23833@SEL-JYOUN-D1> <1458875989.3209.11.camel@perches.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: DaeSeok Youn Cc: Lidza Louina , Mark Hounschell , Greg KH , "driverdev-devel@linuxdriverproject.org" , devel , linux-kernel , kernel-janitors On Fri, 2016-03-25 at 14:42 +0900, DaeSeok Youn wrote: > 2016-03-25 12:19 GMT+09:00 Joe Perches : > > On Fri, 2016-03-25 at 11:44 +0900, Daeseok Youn wrote: > > > fix checkpatch.pl warning about 'line over 80 characters' > > > in dgnc_neo.c [] > > > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c [] > > > @@ -116,7 +117,8 @@ static inline void neo_set_cts_flow_control(struct channel_t *ch) > > >       writeb(efr, &ch->ch_neo_uart->efr); > > > > > >       /* Turn on table D, with 8 char hi/low watermarks */ > > > -     writeb((UART_17158_FCTR_TRGD | UART_17158_FCTR_RTS_4DELAY), &ch->ch_neo_uart->fctr); > > > +     writeb((UART_17158_FCTR_TRGD | UART_17158_FCTR_RTS_4DELAY), > > > +             &ch->ch_neo_uart->fctr); > > You could remove parentheses here around the CONST | CONST > OK. I got it. but it also, I will send a patch after fixing this, not > in this, right? Right.