From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] x86/sfi: Enable enumeration of SD devices
Date: Wed, 07 Sep 2016 12:00:27 +0000 [thread overview]
Message-ID: <1473249627.11323.46.camel@linux.intel.com> (raw)
In-Reply-To: <20160715192348.GA6521@mwanda>
On Tue, 2016-09-06 at 17:51 -0700, Sathyanarayanan Kuppuswamy wrote:
> On 09/01/2016 06:17 AM, Andy Shevchenko wrote:
> > On Tue, 2016-08-30 at 11:18 -0700, Sathyanarayanan Kuppuswamy wrote:
> > IMO, Main problem here is, In some scenarios get_platform_data
> > > returns NULL on error case and in some cases it return NULL for no
> > > platform data case.
> > We have possibility of the following scenarios:
> > 1) fatal error (should return error code and fail booting)
> > 2) non-fatal error (prevents certain device to be enumerated, pdata
> > = NULL)
> > 3) no pdata for the device (not an error! pdata is optional to the
> > certain driver)
> > 4) pdata != NULL (fully armed device driver)
> >
> > According to above I doubt we will have many 1) cases. Otherwise
> > pdata = NULL is okay.
> I agree with 2,3 and 4 scenarios. But I am not sure about the first
> case. Since these are peripheral devices, any failure in them should
> not stop the device boot. Do you have any examples for this case ?
That's what I'm wondering of. I didn't investigate this deep.
In any case for 2) we have to print out a warning (?) message.
> Attached patch fixes the return value issues in get_platform_data
> code
> in device_libs directory. Please check and let me know your comments.
Will do.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-09-07 12:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 19:23 [bug report] x86/sfi: Enable enumeration of SD devices Dan Carpenter
2016-08-09 15:32 ` Andy Shevchenko
2016-08-09 17:58 ` Dan Carpenter
2016-08-28 13:31 ` Andy Shevchenko
2016-08-29 20:59 ` Kuppuswamy, Sathyanarayanan
2016-08-30 9:46 ` Andy Shevchenko
2016-08-30 11:06 ` walter harms
2016-08-30 11:13 ` Andy Shevchenko
2016-08-30 18:18 ` Sathyanarayanan Kuppuswamy
2016-09-07 1:04 ` [PATCH 1/1] intel-mid: Fix sfi get_platform_data() return value issues Kuppuswamy Sathyanarayanan
2016-09-07 12:15 ` Andy Shevchenko
2016-09-08 0:04 ` sathyanarayanan kuppuswamy
2016-09-08 9:49 ` Andy Shevchenko
2016-09-08 0:05 ` [PATCH v2 " Kuppuswamy Sathyanarayanan
2016-09-08 12:51 ` Andy Shevchenko
2016-09-08 22:41 ` sathyanarayanan kuppuswamy
2016-09-09 11:20 ` Andy Shevchenko
2016-09-09 2:07 ` [PATCH v3 1/3] " Kuppuswamy Sathyanarayanan
2016-09-09 2:07 ` [PATCH v3 2/3] intel-mid: Add valid error messages on init failure Kuppuswamy Sathyanarayanan
2016-09-09 11:27 ` Andy Shevchenko
2016-09-09 2:07 ` [PATCH v3 3/3] intel-mid: Move boundry check to the start of init code Kuppuswamy Sathyanarayanan
2016-09-09 11:30 ` Andy Shevchenko
2016-09-01 13:17 ` [bug report] x86/sfi: Enable enumeration of SD devices Andy Shevchenko
2016-09-07 0:51 ` Sathyanarayanan Kuppuswamy
2016-09-07 12:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473249627.11323.46.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).