From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Sat, 24 Sep 2016 17:03:12 +0000 Subject: Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump" Message-Id: <1474736592.23838.8.camel@perches.com> List-Id: References: <3345f7c1-b823-a819-aabf-5b4990068075@users.sourceforge.net> <20160924164108.GB40187@dtor-ws> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Dmitry Torokhov Cc: linux-input@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sat, 2016-09-24 at 18:55 +0200, SF Markus Elfring wrote: > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Why did you split it off from the patch where you attempt to use it? > I chose a special patch granularity once again. > > What good does this change do on its own? > I find that it is a preparation. - If this addition could not be accepted, > the following update step would also be discussed under an other perspective, > wouldn't it? It's purposeless, creates unnecessary patches to review and generally wastes other people's time. Please don't purposefully waste other people's time. It makes your patch proposals _less_ likely to be applied.