From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Date: Mon, 26 Sep 2016 09:12:54 +0000 Subject: Re: [PATCH 3/5] ISDN-CAPI: Adjust 17 function calls together with variable assignments Message-Id: <1474881174.1846.8.camel@tiscali.nl> List-Id: References: <10355972-1c9b-1103-edf3-efde78237cdd@users.sourceforge.net> In-Reply-To: <10355972-1c9b-1103-edf3-efde78237cdd@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: SF Markus Elfring , netdev@vger.kernel.org, Karsten Keil Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sun, 2016-09-25 at 13:13 +0200, SF Markus Elfring wrote: > The script "checkpatch.pl" can point out that assignments should usually > not be performed within condition checks. > Thus move the assignment for a variable to a separate statement > in four functions. Did you recycle this commit explanation? Because git diff tells me you actually touched about eight functions.   > Signed-off-by: Markus Elfring > --- >  drivers/isdn/capi/capidrv.c | 59 +++++++++++++++++++++++++++------------------ >  1 file changed, 36 insertions(+), 23 deletions(-) So I ran checkpatch on this file, just like you did. Specifically, I did:  scripts/checkpatch.pl -f drivers/isdn/capi/capidrv.c | grep "assignment in if condition" | wc -l  It tells me there are actually 18 instances of this "ERROR". Why did you ignore one of it in this patch? Paul Bolle