From: Paul Bolle <pebolle@tiscali.nl>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Tilman Schmidt <tilman@imap.cc>
Cc: Karsten Keil <isdn@linux-pingi.de>,
"David S. Miller" <davem@davemloft.net>,
gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ser_gigaset: return -ENOMEM on error instead of success
Date: Wed, 07 Dec 2016 19:06:23 +0000 [thread overview]
Message-ID: <1481137583.12596.19.camel@tiscali.nl> (raw)
In-Reply-To: <20161207112203.GC5507@elgon.mountain>
On Wed, 2016-12-07 at 14:22 +0300, Dan Carpenter wrote:
> If we can't allocate the resources in gigaset_initdriver() then we
> should return -ENOMEM instead of zero.
That's entirely correct.
> Fixes: 2869b23e4b95 ("[PATCH] drivers/isdn/gigaset: new M101 driver (v2)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Ancient code.
For ancient hardware.
I'll be back (probably tomorrow) after a short test to see whether this really
needs to go into stable. It almost certainly should, but I'd like to first see
the mess the current code leaves behind once gigaset_initdriver() fails before
saying so.
Thanks for reporting this!
Paul Bolle
next prev parent reply other threads:[~2016-12-07 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 11:22 [patch] ser_gigaset: return -ENOMEM on error instead of success Dan Carpenter
2016-12-07 19:06 ` Paul Bolle [this message]
2016-12-07 20:57 ` Tilman Schmidt
2016-12-07 21:08 ` Paul Bolle
2016-12-07 22:04 ` Tilman Schmidt
2016-12-09 9:03 ` Paul Bolle
2016-12-08 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481137583.12596.19.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=isdn@linux-pingi.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox