public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Tilman Schmidt <tilman@imap.cc>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Karsten Keil <isdn@linux-pingi.de>,
	"David S. Miller" <davem@davemloft.net>,
	gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] ser_gigaset: return -ENOMEM on error instead of success
Date: Fri, 09 Dec 2016 09:03:23 +0000	[thread overview]
Message-ID: <1481274203.13252.26.camel@tiscali.nl> (raw)
In-Reply-To: <59908d9c-1716-14cb-41aa-8a9538f53412@imap.cc>

On Wed, 2016-12-07 at 23:04 +0100, Tilman Schmidt wrote:
> Not sure how much evil that does beyond the WARN, but I agree it's
> worth investigating.

For the record: NULL pointer dereference in tty_unregister_ldisc() on module
unload. rmmod got killed, module refcount set -1, etc. My test box locked up
twice some random period after all that. So quite a bit of a mess, all in all.


Paul Bolle

  reply	other threads:[~2016-12-09  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07 11:22 [patch] ser_gigaset: return -ENOMEM on error instead of success Dan Carpenter
2016-12-07 19:06 ` Paul Bolle
2016-12-07 20:57   ` Tilman Schmidt
2016-12-07 21:08     ` Paul Bolle
2016-12-07 22:04       ` Tilman Schmidt
2016-12-09  9:03         ` Paul Bolle [this message]
2016-12-08 19:19 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481274203.13252.26.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=gigaset307x-common@lists.sourceforge.net \
    --cc=isdn@linux-pingi.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox