From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Bolle <pebolle@tiscali.nl>
Date: Fri, 09 Dec 2016 09:03:23 +0000
Subject: Re: [patch] ser_gigaset: return -ENOMEM on error instead of success
Message-Id: <1481274203.13252.26.camel@tiscali.nl>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20161207112203.GC5507@elgon.mountain>
         <1481137583.12596.19.camel@tiscali.nl>
         <d8eb1f69-e68e-7792-00de-b14e6bac1606@imap.cc>
         <1481144894.11167.7.camel@tiscali.nl>
         <59908d9c-1716-14cb-41aa-8a9538f53412@imap.cc>
In-Reply-To: <59908d9c-1716-14cb-41aa-8a9538f53412@imap.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Tilman Schmidt <tilman@imap.cc>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, Karsten Keil <isdn@linux-pingi.de>, "David S. Miller" <davem@davemloft.net>, gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org

On Wed, 2016-12-07 at 23:04 +0100, Tilman Schmidt wrote:
> Not sure how much evil that does beyond the WARN, but I agree it's
> worth investigating.

For the record: NULL pointer dereference in tty_unregister_ldisc() on module
unload. rmmod got killed, module refcount set -1, etc. My test box locked up
twice some random period after all that. So quite a bit of a mess, all in all.


Paul Bolle