From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Chandra Konduru <chandra.konduru@intel.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [patch] drm/i915: return false on failure in intel_dp_compute_config()
Date: Thu, 23 Feb 2017 11:09:14 +0000 [thread overview]
Message-ID: <1487848154.3052.40.camel@linux.intel.com> (raw)
In-Reply-To: <20170223103956.GA27484@mwanda>
On to, 2017-02-23 at 13:39 +0300, Dan Carpenter wrote:
> This function is a bool type where we are supposed to return false on
> failure and true on success. Negative error codes are currently treated
> as true.
>
> Fixes: a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scalers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
<SNIP>
>
> @@ -1637,10 +1637,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> adjusted_mode);
>
> if (INTEL_GEN(dev_priv) >= 9) {
> - int ret;
> - ret = skl_update_scaler_crtc(pipe_config);
> - if (ret)
> - return ret;
> + if (skl_update_scaler_crtc(pipe_config))
> + return false;
> }
You can drop the braces, too.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
next prev parent reply other threads:[~2017-02-23 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 10:39 [patch] drm/i915: return false on failure in intel_dp_compute_config() Dan Carpenter
2017-02-23 11:09 ` Joonas Lahtinen [this message]
2017-02-23 11:20 ` [Intel-gfx] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487848154.3052.40.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chandra.konduru@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox