From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Fri, 21 Apr 2017 18:22:49 +0000 Subject: Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() Message-Id: <1492798969.30293.28.camel@perches.com> List-Id: References: <4d9fbb01-e12f-eb5c-7ecd-5a2a10fd5110@users.sourceforge.net> <20170421113641.GA14100@gondor.apana.org.au> In-Reply-To: <20170421113641.GA14100@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Herbert Xu , SF Markus Elfring Cc: linux-crypto@vger.kernel.org, "David S. Miller" , Matt Mackall , Shannon Nelson , LKML , kernel-janitors@vger.kernel.org On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote: > On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Wed, 19 Apr 2017 10:50:04 +0200 > > > > The script "checkpatch.pl" pointed information out like the following. > > > > WARNING: quoted string split across lines > > > > Thus fix the affected source code places. > > > > Signed-off-by: Markus Elfring > > This patch doesn't seem to add any value so I'm not taking it. Your choice. The general reason to merge strings is in CodingStyle 2) Breaking long lines and strings [] never break user-visible strings such as printk messages, because that breaks the ability to grep for them.