From: Joe Perches <joe@perches.com>
To: "Noralf Trønnes" <noralf@tronnes.org>,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Fengguang Wu" <fengguang.wu@intel.com>,
"Thierry Reding" <treding@nvidia.com>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show()
Date: Tue, 09 May 2017 18:23:19 +0000 [thread overview]
Message-ID: <1494354199.20782.5.camel@perches.com> (raw)
In-Reply-To: <7a6e57ed-7d71-78bc-706e-3a6a1eea3a23@tronnes.org>
On Tue, 2017-05-09 at 19:29 +0200, Noralf Trønnes wrote:
> Den 08.05.2017 13.54, skrev SF Markus Elfring:
> > A single character (line break) should be put into a sequence.
> > Thus use the corresponding function "seq_putc".
Markus, I know this is hard for you,
but think more before sending patches.
> > diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
[]
> > @@ -946,7 +946,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused)
> >
> > for (i = 0; i < len; i++)
> > seq_printf(m, "%02x", val[i]);
> > - seq_puts(m, "\n");
> > + seq_putc(m, '\n');
Use the %p<foo> extensions.
seq_printf(m, "%*phN\n", len, val)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-09 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 11:54 [PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show() SF Markus Elfring
2017-05-09 17:29 ` Noralf Trønnes
2017-05-09 18:23 ` Joe Perches [this message]
2017-05-10 15:15 ` [PATCH] tinydrm: mipi-dbi: Adjust buffer output " SF Markus Elfring
2017-05-10 16:31 ` Noralf Trønnes
2017-05-10 19:26 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494354199.20782.5.camel@perches.com \
--to=joe@perches.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox