* [PATCH] target/iscsi: make function target_parse_xcopy_cmd static
@ 2017-05-11 10:16 Colin King
2017-05-11 13:55 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-05-11 10:16 UTC (permalink / raw)
To: Bart Van Assche, Nicholas A . Bellinger, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Making target_parse_xcopy_cmd static fixes sparse warning:
"warning: symbol 'target_parse_xcopy_cmd' was not declared. Should
it be static?"
Fixes: 1bd05294519f76 ("target/iscsi: Fix a deadlock between the XCOPY code and session shutdown")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/target/target_core_xcopy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
index aecb36d955f0..00e0269e6be4 100644
--- a/drivers/target/target_core_xcopy.c
+++ b/drivers/target/target_core_xcopy.c
@@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work)
* Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing
* fails.
*/
-sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
+static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
{
struct se_cmd *se_cmd = xop->xop_se_cmd;
unsigned char *p = NULL, *seg_desc;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static
2017-05-11 10:16 [PATCH] target/iscsi: make function target_parse_xcopy_cmd static Colin King
@ 2017-05-11 13:55 ` Bart Van Assche
2017-05-11 13:58 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2017-05-11 13:55 UTC (permalink / raw)
To: linux-scsi@vger.kernel.org, colin.king@canonical.com,
target-devel@vger.kernel.org, nab@linux-iscsi.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
T24gVGh1LCAyMDE3LTA1LTExIGF0IDExOjE2ICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG
cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gTWFr
aW5nIHRhcmdldF9wYXJzZV94Y29weV9jbWQgc3RhdGljIGZpeGVzIHNwYXJzZSB3YXJuaW5nOg0K
PiANCj4gIndhcm5pbmc6IHN5bWJvbCAndGFyZ2V0X3BhcnNlX3hjb3B5X2NtZCcgd2FzIG5vdCBk
ZWNsYXJlZC4gIFNob3VsZA0KPiBpdCBiZSBzdGF0aWM/Ig0KPiANCj4gRml4ZXM6IDFiZDA1Mjk0
NTE5Zjc2ICgidGFyZ2V0L2lzY3NpOiBGaXggYSBkZWFkbG9jayBiZXR3ZWVuIHRoZSBYQ09QWSBj
b2RlIGFuZCBzZXNzaW9uIHNodXRkb3duIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtp
bmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL3RhcmdldC90
YXJnZXRfY29yZV94Y29weS5jIHwgMiArLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u
KCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy90YXJnZXQvdGFy
Z2V0X2NvcmVfeGNvcHkuYyBiL2RyaXZlcnMvdGFyZ2V0L3RhcmdldF9jb3JlX3hjb3B5LmMNCj4g
aW5kZXggYWVjYjM2ZDk1NWYwLi4wMGUwMjY5ZTZiZTQgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMv
dGFyZ2V0L3RhcmdldF9jb3JlX3hjb3B5LmMNCj4gKysrIGIvZHJpdmVycy90YXJnZXQvdGFyZ2V0
X2NvcmVfeGNvcHkuYw0KPiBAQCAtODg2LDcgKzg4Niw3IEBAIHN0YXRpYyB2b2lkIHRhcmdldF94
Y29weV9kb193b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykNCj4gICAqIFJldHVybnMgVENN
X05PX1NFTlNFIHVwb24gc3VjY2VzcyBvciBhIHNlbnNlIGNvZGUgIT0gVENNX05PX1NFTlNFIGlm
IHBhcnNpbmcNCj4gICAqIGZhaWxzLg0KPiAgICovDQo+IC1zZW5zZV9yZWFzb25fdCB0YXJnZXRf
cGFyc2VfeGNvcHlfY21kKHN0cnVjdCB4Y29weV9vcCAqeG9wKQ0KPiArc3RhdGljIHNlbnNlX3Jl
YXNvbl90IHRhcmdldF9wYXJzZV94Y29weV9jbWQoc3RydWN0IHhjb3B5X29wICp4b3ApDQo+ICB7
DQo+ICAJc3RydWN0IHNlX2NtZCAqc2VfY21kID0geG9wLT54b3Bfc2VfY21kOw0KPiAgCXVuc2ln
bmVkIGNoYXIgKnAgPSBOVUxMLCAqc2VnX2Rlc2M7DQoNCkhlbGxvIENvbGluLA0KDQpUaGFua3Mg
Zm9yIHRoZSBwYXRjaC4gSSB3aWxsIG1lcmdlIGl0IGluIHBhdGNoICJ0YXJnZXQvaXNjc2k6IEZp
eCBhIGRlYWRsb2NrIGJldHdlZW4gdGhlDQpYQ09QWSBjb2RlIGFuZCBzZXNzaW9uIHNodXRkb3du
Ii4NCg0KQmFydC4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static
2017-05-11 13:55 ` Bart Van Assche
@ 2017-05-11 13:58 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2017-05-11 13:58 UTC (permalink / raw)
To: Bart Van Assche, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, nab@linux-iscsi.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
On 11/05/17 14:55, Bart Van Assche wrote:
> On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Making target_parse_xcopy_cmd static fixes sparse warning:
>>
>> "warning: symbol 'target_parse_xcopy_cmd' was not declared. Should
>> it be static?"
>>
>> Fixes: 1bd05294519f76 ("target/iscsi: Fix a deadlock between the XCOPY code and session shutdown")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/target/target_core_xcopy.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
>> index aecb36d955f0..00e0269e6be4 100644
>> --- a/drivers/target/target_core_xcopy.c
>> +++ b/drivers/target/target_core_xcopy.c
>> @@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work)
>> * Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing
>> * fails.
>> */
>> -sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
>> +static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
>> {
>> struct se_cmd *se_cmd = xop->xop_se_cmd;
>> unsigned char *p = NULL, *seg_desc;
>
> Hello Colin,
>
> Thanks for the patch. I will merge it in patch "target/iscsi: Fix a deadlock between the
> XCOPY code and session shutdown".
>
> Bart.
>
Thanks, sounds good to me.
Colin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-11 13:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 10:16 [PATCH] target/iscsi: make function target_parse_xcopy_cmd static Colin King
2017-05-11 13:55 ` Bart Van Assche
2017-05-11 13:58 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox