Re: [PATCH] MIPS: Octeon: Delete an error message for a failed memory allocation in octeon_irq_init_

SF Markus Elfring
2017-05-24T16:01:39Z

>> +++ b/arch/mips/cavium-octeon/octeon-irq.c
>> @@ -1615,7 +1615,6 @@ static int __init octeon_irq_init_gpio(
>> irq_domain_add_linear(
>> gpio_node, 16, &octeon_irq_domain_gpio_ops, gpiod);
>> } else {
>> - pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
>> return -ENOMEM;
>> }
>
> You really should reverse the test here and
> unindent the first block.

Thanks for your improved source code transformation.

I am curious if I will stumble on a similar change possibility once more
for remaining update candidates in other software areas.

Regards,
Markus