From: Luca Coelho <luca@coelho.fi>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Johannes Berg <johannes.berg@intel.com>,
Haim Dreyfuss <haim.dreyfuss@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
Sara Sharon <sara.sharon@intel.com>,
Liad Kaufman <liad.kaufman@intel.com>,
Sharon Dvir <sharon.dvir@intel.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: missing error code in iwl_trans_pcie_alloc()
Date: Wed, 14 Jun 2017 10:49:11 +0000 [thread overview]
Message-ID: <1497437351.26841.45.camel@coelho.fi> (raw)
In-Reply-To: <20170614104450.GN29394@elgon.mountain>
On Wed, 2017-06-14 at 13:44 +0300, Dan Carpenter wrote:
> We don't set the error code here so we end up returning ERR_PTR(0) which
> is NULL. The caller doesn't expect that so it results in a NULL
> dereference.
>
> Fixes: 2e5d4a8f61dc ("iwlwifi: pcie: Add new configuration to enable MSIX")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch, thanks!
I'll push it to our internal tree, so it will go upstream via our normal
process.
--
Cheers,
Luca.
prev parent reply other threads:[~2017-06-14 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 10:44 [PATCH] iwlwifi: missing error code in iwl_trans_pcie_alloc() Dan Carpenter
2017-06-14 10:49 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497437351.26841.45.camel@coelho.fi \
--to=luca@coelho.fi \
--cc=dan.carpenter@oracle.com \
--cc=emmanuel.grumbach@intel.com \
--cc=haim.dreyfuss@intel.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=liad.kaufman@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=sara.sharon@intel.com \
--cc=sharon.dvir@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox