From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Chang Date: Mon, 07 Aug 2017 02:42:05 +0000 Subject: Re: [PATCH 05/12] [media] vcodec: mediatek: constify v4l2_m2m_ops structures Message-Id: <1502073725.2886.2.camel@mtksdaap41> List-Id: References: <1502007921-22968-1-git-send-email-Julia.Lawall@lip6.fr> <1502007921-22968-6-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1502007921-22968-6-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Sun, 2017-08-06 at 10:25 +0200, Julia Lawall wrote: > The v4l2_m2m_ops structures are only passed as the only > argument to v4l2_m2m_init, which is declared as const. > Thus the v4l2_m2m_ops structures themselves can be const. > > Done with the help of Coccinelle. > > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct v4l2_m2m_ops i@p = { ... }; > > @ok1@ > identifier r.i; > position p; > @@ > v4l2_m2m_init(&i@p) > > @bad@ > position p != {r.p,ok1.p}; > identifier r.i; > struct v4l2_m2m_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct v4l2_m2m_ops i = { ... }; > // > > Signed-off-by: Julia Lawall > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Rick Chang