From: Doug Ledford <dledford@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Saeed Mahameed <saeedm@mellanox.com>
Cc: Matan Barak <matanb@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: add a missing tab
Date: Mon, 28 Aug 2017 23:09:47 +0000 [thread overview]
Message-ID: <1503961787.52034.6.camel@redhat.com> (raw)
In-Reply-To: <20170801110101.mf2i5e2mes4ftmkj@mwanda>
On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote:
> The code works as intended, but the indenting is confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
You didn't include netdev on this patch, and I haven't seen a note from
janitors that they took it, so I decided to send it on through. It's
minor enough it shouldn't be an issue conflicting with Dave's tree I
would think. I'll know I was wrong if I get yelled at.
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> index 28d8472b36f1..c410360da58d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> @@ -113,7 +113,7 @@ static int mlx5_device_enable_sriov(struct
> mlx5_core_dev *dev, int num_vfs)
> mlx5_core_warn(dev,
> "failed to restore VF
> %d settings, err %d\n",
> vf, err);
> - continue;
> + continue;
> }
> }
> mlx5_core_dbg(dev, "successfully enabled VF* %d\n",
> vf);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
next prev parent reply other threads:[~2017-08-28 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 11:01 [PATCH] net/mlx5: add a missing tab Dan Carpenter
2017-08-28 23:09 ` Doug Ledford [this message]
2017-08-29 9:14 ` Dan Carpenter
2017-08-29 12:29 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503961787.52034.6.camel@redhat.com \
--to=dledford@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox