From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Fri, 22 Sep 2017 10:03:08 +0000 Subject: Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Message-Id: <1506074588.12311.37.camel@perches.com> List-Id: References: <20170921225630.21916-1-colin.king@canonical.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall , Colin King Cc: Stanislaw Gruszka , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote: > > On Thu, 21 Sep 2017, Colin King wrote: > > > From: Colin Ian King > > > > Don't populate const array ac_to_fifo on the stack in an inlined > > function, instead make it static. Makes the object code smaller > > by over 800 bytes: > > > > text data bss dec hex filename > > 159029 33154 1216 193399 2f377 4965-mac.o > > > > text data bss dec hex filename > > 158122 33250 1216 192588 2f04c 4965-mac.o > > > > (gcc version 7.2.0 x86_64) > > Gcc 7 must be much more aggressive about inlining than gcc 4. Here is the > change that I got on this file: > > text data bss dec hex filename > - 76346 1494 152 77992 130a8 drivers/net/wireless/intel/iwlegacy/4965-mac.o > + 76298 1494 152 77944 13078 drivers/net/wireless/intel/iwlegacy/4965-mac.o > decrease of 48 More likely different CONFIG options. e.g. allyesconfig vs defconfig with wireless