From: Joe Perches <joe@perches.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
Jan Kara <jack@suse.cz>, Lorenzo Stoakes <lstoakes@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Muralidharan Karicheri <mkaricheri@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vo
Date: Sun, 24 Sep 2017 10:35:23 +0000 [thread overview]
Message-ID: <1506249323.11186.3.camel@perches.com> (raw)
In-Reply-To: <c949fbd6-0a01-d6e7-d6f9-d55dbf5dce5e@users.sourceforge.net>
On Sun, 2017-09-24 at 12:22 +0200, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
[]
> diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
[]
> @@ -1948,7 +1948,5 @@ static int __init omap_vout_create_video_devices(struct platform_device *pdev)
> - if (!vout) {
> - dev_err(&pdev->dev, ": could not allocate memory\n");
> + if (!vout)
> return -ENOMEM;
> - }
>
> vout->vid = k;
> vid_dev->vouts[k] = vout;
Use normal patch styles.
Fix your tools before you send any more patches.
next prev parent reply other threads:[~2017-09-24 10:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 10:20 [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations SF Markus Elfring
2017-09-24 10:22 ` [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_c SF Markus Elfring
2017-09-24 10:35 ` Joe Perches [this message]
2017-09-24 10:24 ` [PATCH 2/6] [media] omap_vout: Improve a size determination in two functions SF Markus Elfring
2017-09-24 10:26 ` [PATCH 3/6] [media] omap_vout: Adjust a null pointer check " SF Markus Elfring
2017-09-24 10:28 ` [PATCH 4/6] [media] omap_vout: Fix a possible null pointer dereference in omap_vout_open() SF Markus Elfring
2017-09-24 10:30 ` [PATCH 5/6] [media] omap_vout: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-09-24 10:33 ` [PATCH 6/6] [media] omap_vout: Delete two unnecessary variable initialisations in omap_vout_probe() SF Markus Elfring
2017-10-30 8:36 ` [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations Hans Verkuil
2017-10-30 9:16 ` Adjustments for a lot of " SF Markus Elfring
2017-10-30 9:47 ` Julia Lawall
2017-10-30 9:57 ` Hans Verkuil
2017-10-30 10:40 ` SF Markus Elfring
2017-10-30 10:48 ` Hans Verkuil
2017-10-30 11:41 ` SF Markus Elfring
2017-11-26 19:06 ` SF Markus Elfring
2018-01-08 11:44 ` SF Markus Elfring
2018-02-02 9:55 ` SF Markus Elfring
2018-02-02 10:29 ` Hans Verkuil
2018-02-02 12:30 ` SF Markus Elfring
2018-02-10 8:39 ` SF Markus Elfring
2017-10-31 8:27 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506249323.11186.3.camel@perches.com \
--to=joe@perches.com \
--cc=elfring@users.sourceforge.net \
--cc=hverkuil@xs4all.nl \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mchehab@kernel.org \
--cc=mhocko@suse.com \
--cc=mkaricheri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox