[PATCH] i40iw: delete some stray tabs

[PATCH] i40iw: delete some stray tabs

[Dan Carpenter]

These lines were indented too far by mistake.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
index 5230dd3c938c..9017c1cc51d4 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
@@ -1524,8 +1524,8 @@ static bool i40iw_port_in_use(struct i40iw_cm_core *cm_core, u16 port, bool acti
 				break;
 			}
 		}
-			if (!ret)
-				clear_bit(port, cm_core->active_side_ports);
+		if (!ret)
+			clear_bit(port, cm_core->active_side_ports);
 		spin_unlock_irqrestore(&cm_core->ht_lock, flags);
 	} else {
 		spin_lock_irqsave(&cm_core->listen_list_lock, flags);

Re: [PATCH] i40iw: delete some stray tabs

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote:
> These lines were indented too far by mistake.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c

Dan,,

I saw in your patches and don't know if it important. There is no
diffstat after your Signed-off-by and there is no "---" trailing line
too.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] i40iw: delete some stray tabs

[Dan Carpenter]

On Fri, Sep 29, 2017 at 01:29:29PM +0300, Leon Romanovsky wrote:
> On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote:
> > These lines were indented too far by mistake.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> 
> Dan,,
> 
> I saw in your patches and don't know if it important. There is no
> diffstat after your Signed-off-by and there is no "---" trailing line
> too.

Yeah.  I leave those out.  I normally write two line patches like this
one so the diffstat is normally -2+2 and I figure people will see that
they're tiny just from glancing at the email.  When I create patches
that touch multiple files, what I do is just merge the diffs together in
my email client.  If I tried to create diffstats for those, I'd just end
up messing up a lot.

regards,
dan carpenter

Re: [PATCH] i40iw: delete some stray tabs

[Shiraz Saleem]

On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote:
> These lines were indented too far by mistake.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> index 5230dd3c938c..9017c1cc51d4 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> @@ -1524,8 +1524,8 @@ static bool i40iw_port_in_use(struct i40iw_cm_core *cm_core, u16 port, bool acti
>  				break;
>  			}
>  		}
> -			if (!ret)
> -				clear_bit(port, cm_core->active_side_ports);
> +		if (!ret)
> +			clear_bit(port, cm_core->active_side_ports);
>  		spin_unlock_irqrestore(&cm_core->ht_lock, flags);
>  	} else {
>  		spin_lock_irqsave(&cm_core->listen_list_lock, flags);
> --

Thanks Dan!
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>

Re: [PATCH] i40iw: delete some stray tabs

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

On Fri, Sep 29, 2017 at 01:40:04PM +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2017 at 01:29:29PM +0300, Leon Romanovsky wrote:
> > On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote:
> > > These lines were indented too far by mistake.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> >
> > Dan,,
> >
> > I saw in your patches and don't know if it important. There is no
> > diffstat after your Signed-off-by and there is no "---" trailing line
> > too.
>
> Yeah.  I leave those out.  I normally write two line patches like this
> one so the diffstat is normally -2+2 and I figure people will see that
> they're tiny just from glancing at the email.  When I create patches
> that touch multiple files, what I do is just merge the diffs together in
> my email client.  If I tried to create diffstats for those, I'd just end
> up messing up a lot.

What are the benefits avoiding them?

I personally want to see them without and conditions, for two reasons:
1. It helps me to see the scope of the change.
2. It allows me to simply copy/paste the name to the editor without need
to remove "a/" or "b/" from the "diff --git" line.

Thanks

>
> regards,
> dan carpenter
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] i40iw: delete some stray tabs

[Doug Ledford]

On Fri, 2017-09-29 at 10:49 +0300, Dan Carpenter wrote:
> These lines were indented too far by mistake.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [PATCH] i40iw: delete some stray tabs

[Dan Carpenter]

On Fri, Sep 29, 2017 at 05:45:54PM +0300, Leon Romanovsky wrote:
> On Fri, Sep 29, 2017 at 01:40:04PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 29, 2017 at 01:29:29PM +0300, Leon Romanovsky wrote:
> > > On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote:
> > > > These lines were indented too far by mistake.
> > > >
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > >
> > > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> > >
> > > Dan,,
> > >
> > > I saw in your patches and don't know if it important. There is no
> > > diffstat after your Signed-off-by and there is no "---" trailing line
> > > too.
> >
> > Yeah.  I leave those out.  I normally write two line patches like this
> > one so the diffstat is normally -2+2 and I figure people will see that
> > they're tiny just from glancing at the email.  When I create patches
> > that touch multiple files, what I do is just merge the diffs together in
> > my email client.  If I tried to create diffstats for those, I'd just end
> > up messing up a lot.
> 
> What are the benefits avoiding them?
> 

The way I develop the kernel is way different from how other people do
and different from how I develop Smatch.  I've spent 9 years tweaking
my scripts to make it work for me.  Please don't force me to use git
commit...  :(

regards,
dan carpenter

Re: [PATCH] i40iw: delete some stray tabs

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

On Fri, Sep 29, 2017 at 11:34:09PM +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2017 at 05:45:54PM +0300, Leon Romanovsky wrote:
> > On Fri, Sep 29, 2017 at 01:40:04PM +0300, Dan Carpenter wrote:
> > > On Fri, Sep 29, 2017 at 01:29:29PM +0300, Leon Romanovsky wrote:
> > > > On Fri, Sep 29, 2017 at 10:49:43AM +0300, Dan Carpenter wrote:
> > > > > These lines were indented too far by mistake.
> > > > >
> > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > > >
> > > > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> > > >
> > > > Dan,,
> > > >
> > > > I saw in your patches and don't know if it important. There is no
> > > > diffstat after your Signed-off-by and there is no "---" trailing line
> > > > too.
> > >
> > > Yeah.  I leave those out.  I normally write two line patches like this
> > > one so the diffstat is normally -2+2 and I figure people will see that
> > > they're tiny just from glancing at the email.  When I create patches
> > > that touch multiple files, what I do is just merge the diffs together in
> > > my email client.  If I tried to create diffstats for those, I'd just end
> > > up messing up a lot.
> >
> > What are the benefits avoiding them?
> >
>
> The way I develop the kernel is way different from how other people do
> and different from how I develop Smatch.  I've spent 9 years tweaking
> my scripts to make it work for me.  Please don't force me to use git
> commit...  :(

I had no intentions to do so.

>
> regards,
> dan carpenter
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]