kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	SF Markus Elfring <elfring@users.sourceforge.net>
Cc: kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/trace: Delete five error messages for a failed memory allocation
Date: Mon, 09 Oct 2017 20:20:09 +0000	[thread overview]
Message-ID: <1507580409.3552.15.camel@perches.com> (raw)
In-Reply-To: <20171009161337.7c35911f@gandalf.local.home>

On Mon, 2017-10-09 at 16:13 -0400, Steven Rostedt wrote:
> On Sat, 7 Oct 2017 16:15:14 +0200
> SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> 
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sat, 7 Oct 2017 16:10:06 +0200
> > 
> > Omit extra messages for a memory allocation failure in these functions.
> 
> Does memory allocation failures have printk messages? If not, then I
> think this is removing useful information.

Every k.alloc failure without __GFP_NOWARN does a dump_stack()


      reply	other threads:[~2017-10-09 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-07 14:15 [PATCH] kernel/trace: Delete five error messages for a failed memory allocation SF Markus Elfring
2017-10-09 20:13 ` Steven Rostedt
2017-10-09 20:20   ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507580409.3552.15.camel@perches.com \
    --to=joe@perches.com \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).