From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Date: Sat, 14 Oct 2017 15:22:46 +0000
Subject: Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
Message-Id: <1507994566.814.17.camel@perches.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20171014145224.840-1-colin.king@canonical.com>
In-Reply-To: <20171014145224.840-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-security-module@vger.kernel.org

On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
> 
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
>  	u32 i, chain_len, slots_used, max_chain_len;
>  	struct hashtab_node *cur;
>  
> -	slots_used = 0;
> -	max_chain_len = 0;
>  	for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
>  		cur = h->htable[i];
>  		if (cur) {

I think it'd be nicer if the assignments in the loop
were removed instead.

	slots_used = 0;
	max_chain_len = 0;
	for (i = 0; i < h->size; i++) {
		etc...