Re: [PATCH v2] video: atmel_lcdfb: Use unique error messages in atmel_lcdfb_of_init()

Joe Perches
2017-11-06T18:32:33Z

On Mon, 2017-11-06 at 19:14 +0100, SF Markus Elfring wrote:
> A duplicate error message was used so far in this function implementation.
> Thus use a consistent message format instead together with property names
> where constant merging can be applied by the compiler in four cases.
[]
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
[]
> @@ -1021,6 +1021,8 @@ static void atmel_lcdfb_power_control_gpio(struct atmel_lcdfb_pdata *pdata, int
> gpio_set_value(og->gpio, on);
> }
>
> +static char const property_failure[] = "failed to get property %s\n";

Yuck. This makes it harder to grep the sources.
Just use the normal format string in each place.

> +
> static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
> {
> struct fb_info *info = sinfo->info;
> @@ -1048,25 +1050,25 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
>
> ret = of_property_read_u32(display_np, "bits-per-pixel", &var->bits_per_pixel);
> if (ret < 0) {
> - dev_err(dev, "failed to get property bits-per-pixel\n");
> + dev_err(dev, property_failure, "bits-per-pixel");

This likely doesn't even save any code size.