From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 27 Nov 2017 01:12:45 +0000 Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line Message-Id: <1511745165.20482.34.camel@perches.com> List-Id: References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Logan Gunthorpe , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft On Sun, 2017-11-26 at 23:44 +0100, Julia Lawall wrote: > My semantic patch and results are below. The semantic patch has some > features that may or may not be desired: > > 1. It goes beyond printk, pr_xxx, dev_xxx, and netdev_xxx, by finding > functions that are sometimes used with a format string ending with a > newline. To reduce false positives, such a function is ignored if it is > sometimes used with a string that ends in a space. This could lead to > false positives where actually one of the calls has a \n that it should > not have. > > 2. Coccinelle puts multipart strings on a single line. So the rule goes > a little further and eliminates the multipartness. Basically "xxx " "yyy" > becomes "xxx yyy" regardless of the length of the result. What about the semi-common string concatenation "foo" #var "bar" ? > 3. Some prints appear not to end with a newline because they end with \n. > where .\n was likely intended. Instead of creating \n.\n, the semantic > patch just moves the .to the left of the . And if there was .\n. it just > drops the final period. That may be a problem if the sentence is "something...\n" There seem to be many false positives in here too. cheers, Joe