From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 27 Nov 2017 17:42:48 +0000 Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line Message-Id: <1511804568.32426.56.camel@perches.com> List-Id: References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com> <86f3f594-79f7-c2ce-2cc6-f641bd6f55ae@deltatee.com> <1511771322.32426.1.camel@perches.com> <1511803686.32426.54.camel@perches.com> <322acd87-7708-cc90-c3d1-caad7bd023e5@deltatee.com> In-Reply-To: <322acd87-7708-cc90-c3d1-caad7bd023e5@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Logan Gunthorpe , Julia Lawall Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft On Mon, 2017-11-27 at 10:35 -0700, Logan Gunthorpe wrote: > > On 27/11/17 10:28 AM, Joe Perches wrote: > > It doesn't miss any mark. It simply informs. > > Correctness when fixing are a different world of problems. > > So how come the double standard? No double stardard. One correctly informs that a bare printk is not acceptable. > Having a missing new line warning > simply informs here too. No it has a high false positive rate and newbies act on that by submitting bad patches.'