From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Mon, 11 Dec 2017 11:54:03 +0000 Subject: Re: [PATCH] ASoC: Intel: Skylake: Re-order some code to silence a warning Message-Id: <1512993243.25007.592.camel@linux.intel.com> List-Id: References: <20171208115425.rqclgmhcph5gn47j@mwanda> <1512991223.25007.590.camel@linux.intel.com> <20171211113345.ubl7rj7ftt62ox5s@mwanda> In-Reply-To: <20171211113345.ubl7rj7ftt62ox5s@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Liam Girdwood , Sriram Periyasamy , Mark Brown , Jaroslav Kysela , Takashi Iwai , "Subhransu S. Prusty" , Jani Nikula , Guneshwor Singh , Pankaj Bharadiya , Senthilnathan Veppur , Vinod Koul , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org On Mon, 2017-12-11 at 14:33 +0300, Dan Carpenter wrote: > On Mon, Dec 11, 2017 at 01:20:23PM +0200, Andy Shevchenko wrote: > > On Fri, 2017-12-08 at 14:54 +0300, Dan Carpenter wrote: > > > > > I didn't like the way the code was written either but it's impossible > to know how much change people are going to accept. Even though I > think > that extra parenthesis shouldn't have been there, the original author > felt they helped, so I try to be accomodating... > > Anyway, I can resend. Since Vinod ACKed this change, I'm fine with it. Consider my comment as JFYI. -- Andy Shevchenko Intel Finland Oy