* [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_probe
@ 2018-02-11 12:42 SF Markus Elfring
2018-02-12 10:08 ` [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_p Andy Shevchenko
2018-02-22 14:19 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-02-11 12:42 UTC (permalink / raw)
To: linux-gpio, Andy Shevchenko, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 11 Feb 2018 13:30:14 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpio/gpio-merrifield.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-merrifield.c
index dd67a31ac337..eec21122299e 100644
--- a/drivers/gpio/gpio-merrifield.c
+++ b/drivers/gpio/gpio-merrifield.c
@@ -408,10 +408,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev, const struct pci_device_id *id
pcim_iounmap_regions(pdev, BIT(1));
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "can't allocate chip data\n");
+ if (!priv)
return -ENOMEM;
- }
priv->dev = &pdev->dev;
priv->reg_base = pcim_iomap_table(pdev)[0];
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_p
2018-02-11 12:42 [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_probe SF Markus Elfring
@ 2018-02-12 10:08 ` Andy Shevchenko
2018-02-22 14:19 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-02-12 10:08 UTC (permalink / raw)
To: SF Markus Elfring, linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
On Sun, 2018-02-11 at 13:42 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 11 Feb 2018 13:30:14 +0100
>
> Omit an extra message for a memory allocation failure in this
> function.
>
> This issue was detected by using the Coccinelle software.
>
Linus, I have no strong opinion here, so, up to you to decide.
If you decide this patch to go,
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/gpio/gpio-merrifield.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-
> merrifield.c
> index dd67a31ac337..eec21122299e 100644
> --- a/drivers/gpio/gpio-merrifield.c
> +++ b/drivers/gpio/gpio-merrifield.c
> @@ -408,10 +408,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev,
> const struct pci_device_id *id
> pcim_iounmap_regions(pdev, BIT(1));
>
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv) {
> - dev_err(&pdev->dev, "can't allocate chip data\n");
> + if (!priv)
> return -ENOMEM;
> - }
>
> priv->dev = &pdev->dev;
> priv->reg_base = pcim_iomap_table(pdev)[0];
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_p
2018-02-11 12:42 [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_probe SF Markus Elfring
2018-02-12 10:08 ` [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_p Andy Shevchenko
@ 2018-02-22 14:19 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-02-22 14:19 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, Andy Shevchenko, LKML, kernel-janitors
On Sun, Feb 11, 2018 at 1:42 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 11 Feb 2018 13:30:14 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-22 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-11 12:42 [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_probe SF Markus Elfring
2018-02-12 10:08 ` [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_p Andy Shevchenko
2018-02-22 14:19 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox