From: David Howells <dhowells@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] KEYS: testing wrong bit for KEY_FLAG_REVOKED
Date: Tue, 06 Mar 2012 11:22:33 +0000 [thread overview]
Message-ID: <15205.1331032953@redhat.com> (raw)
In-Reply-To: <20120305082902.GA10894@elgon.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The test for "if (cred->request_key_auth->flags & KEY_FLAG_REVOKED) {"
> should actually be "if (test_bit(KEY_FLAG_REVOKED, &req_key->flags)) {".
> The current code actually checks for KEY_FLAG_DEAD.
Looks okay.
> The patch is really a one liner but I introduced a new variable so that
> I don't go over the 80 character limit.
Just split the arguments for test_bit() onto separate lines.
David
next prev parent reply other threads:[~2012-03-06 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 8:29 [patch] KEYS: testing wrong bit for KEY_FLAG_REVOKED Dan Carpenter
2012-03-06 11:22 ` David Howells [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-06 13:32 [PATCH] " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15205.1331032953@redhat.com \
--to=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).