* Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()
@ 2018-03-13 7:24 SF Markus Elfring
2018-03-13 10:26 ` Oliver Neukum
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2018-03-13 7:24 UTC (permalink / raw)
To: Oliver Neukum, linux-usb, netdev
Cc: kernel-janitors, LKML, Andrew F. Davis, Andrew Lunn,
Bjørn Mork, David S. Miller, Philippe Reynes, Yuval Shaia
>> Use three values directly for a condition check without assigning them
>> to intermediate variables.
>
> Hi,
>
> what is the benefit of this?
I proposed a small source code reduction.
Other software design directions might become more interesting for this use case.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()
2018-03-13 7:24 [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee() SF Markus Elfring
@ 2018-03-13 10:26 ` Oliver Neukum
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Neukum @ 2018-03-13 10:26 UTC (permalink / raw)
To: SF Markus Elfring, linux-usb, netdev
Cc: David S. Miller, Philippe Reynes, Andrew Lunn, Bjørn Mork,
Yuval Shaia, Andrew F. Davis, kernel-janitors, LKML
Am Dienstag, den 13.03.2018, 08:24 +0100 schrieb SF Markus Elfring:
> >
> > >
> > > Use three values directly for a condition check without assigning them
> > > to intermediate variables.
> >
> > Hi,
> >
> > what is the benefit of this?
>
> I proposed a small source code reduction.
>
> Other software design directions might become more interesting for this use case.
Yes and doing so you killed three meaningful names that tell
us what these checks actually test for. That is not an improvement.
Regards
Oliver
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-13 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-13 7:24 [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee() SF Markus Elfring
2018-03-13 10:26 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).