From: Jon Hunter <jonathanh@nvidia.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, "Rob Herring" <robh@kernel.org>,
Vidya Sagar <vidyas@nvidia.com>,
Jingoo Han <jingoohan1@gmail.com>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] PCI: tegra: Fix build warnings when CONFIG_PCIEASPM is not set
Date: Thu, 20 May 2021 14:50:51 +0100 [thread overview]
Message-ID: <152ea963-1a3f-eba6-93d9-95161b8f7b7d@nvidia.com> (raw)
In-Reply-To: <20210520134209.1667244-1-weiyongjun1@huawei.com>
On 20/05/2021 14:42, Wei Yongjun wrote:
> Fix build warning when CONFIG_PCIEASPM is not set:
>
> drivers/pci/controller/dwc/pcie-tegra194.c:259:18: warning:
> 'event_cntr_data_offset' defined but not used [-Wunused-const-variable=]
> 259 | static const u32 event_cntr_data_offset[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/pci/controller/dwc/pcie-tegra194.c:250:18: warning:
> 'event_cntr_ctrl_offset' defined but not used [-Wunused-const-variable=]
> 250 | static const u32 event_cntr_ctrl_offset[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/pci/controller/dwc/pcie-tegra194.c:243:27: warning:
> 'pcie_gen_freq' defined but not used [-Wunused-const-variable=]
> 243 | static const unsigned int pcie_gen_freq[] = {
> | ^~~~~~~~~~~~~
>
> Fix it by only define then when CONFIG_PCIEASPM is set.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks but this has already been reported and there is a fix available [0].
Jon
[0]
https://patchwork.ozlabs.org/project/linux-tegra/patch/20210520090123.11814-1-jonathanh@nvidia.com/
--
nvpublic
prev parent reply other threads:[~2021-05-20 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 13:42 [PATCH -next] PCI: tegra: Fix build warnings when CONFIG_PCIEASPM is not set Wei Yongjun
2021-05-20 13:50 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152ea963-1a3f-eba6-93d9-95161b8f7b7d@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox