From: Philipp Zabel <p.zabel@pengutronix.de>
To: Colin King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] reset: fix null pointer dereference on dev by dev_name
Date: Thu, 15 Nov 2018 09:33:14 +0000 [thread overview]
Message-ID: <1542274394.4915.6.camel@pengutronix.de> (raw)
In-Reply-To: <20181114214935.16038-1-colin.king@canonical.com>
Hi Colin,
On Wed, 2018-11-14 at 21:49 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to dev_name will dereference dev, however, dev is later
> being null checked, so there is a possibility of a null pointer
> dereference on dev by the call to dev_name. Fix this by null
> checking dev first before the call to dev_name
>
> Detected by CoverityScan, CID#1475475 ("Dereference before null check")
>
> Fixes: 2a6cb2b1d83b ("reset: Add reset_control_get_count()")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thank you, applied to reset/next.
regards
Philipp
prev parent reply other threads:[~2018-11-15 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 21:49 [PATCH][next] reset: fix null pointer dereference on dev by dev_name Colin King
2018-11-15 9:33 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542274394.4915.6.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox