From: Wei Yongjun <weiyongjun1@huawei.com>
To: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, christian@brauner.io
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH v3] binderfs: fix error return code in binderfs_fill_super()
Date: Wed, 16 Jan 2019 10:39:21 +0000 [thread overview]
Message-ID: <1547635161-62311-1-git-send-email-weiyongjun1@huawei.com> (raw)
In-Reply-To: <1547627642-96450-1-git-send-email-weiyongjun1@huawei.com>
Fix to return a negative error code -ENOMEM from the new_inode() and
d_make_root() error handling cases instead of 0, as done elsewhere in
this function.
Fixes: 849d540ddfcd ("binderfs: implement "max" mount option")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: move 'ret = -ENOMEM' out of if
v2 -> v3: use correct fixes commit
---
drivers/android/binderfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 9518e2e..e4ff4c3 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -518,6 +518,7 @@ static int binderfs_fill_super(struct super_block *sb, void *data, int silent)
sb->s_fs_info = info;
+ ret = -ENOMEM;
inode = new_inode(sb);
if (!inode)
goto err_without_dentry;
next prev parent reply other threads:[~2019-01-16 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 2:55 [PATCH -next] binderfs: fix error return code in binderfs_fill_super() Wei Yongjun
2019-01-16 6:25 ` Christian Brauner
2019-01-16 6:28 ` Christian Brauner
2019-01-16 6:53 ` Greg KH
2019-01-16 8:54 ` Dan Carpenter
2019-01-16 8:34 ` [PATCH -next v2] " Wei Yongjun
2019-01-16 8:41 ` Christian Brauner
2019-01-16 8:45 ` Christian Brauner
2019-01-16 10:39 ` Wei Yongjun [this message]
2019-01-16 10:34 ` [PATCH v3] " weiyongjun (A)
2019-01-16 10:42 ` [PATCH v4] " Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547635161-62311-1-git-send-email-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox