From: Philipp Zabel <p.zabel@pengutronix.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] drm/imx: imx-ldb: add missing of_node_puts
Date: Thu, 17 Jan 2019 14:00:38 +0000 [thread overview]
Message-ID: <1547733638.4009.11.camel@pengutronix.de> (raw)
In-Reply-To: <1547369264-24831-3-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
On Sun, 2019-01-13 at 09:47 +0100, Julia Lawall wrote:
> The device node iterators perform an of_node_get on each
> iteration, so a jump out of the loop requires an of_node_put.
>
> Move the initialization channel->child = child; down to just
> before the call to imx_ldb_register so that intervening failures
> don't need to clear it. Add a label at the end of the function to
> do all the of_node_puts.
Thank you, I've applied the patch to the imx-drm/fixes branch.
regards
Philipp
next prev parent reply other threads:[~2019-01-17 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 8:47 [PATCH 0/4] add missing of_node_puts Julia Lawall
2019-01-13 8:47 ` [PATCH 1/4] drm/mediatek: " Julia Lawall
2019-01-13 8:47 ` [PATCH 2/4] drm/imx: imx-ldb: " Julia Lawall
2019-01-17 14:00 ` Philipp Zabel [this message]
2019-01-13 8:47 ` [PATCH 3/4] drm/rockchip: add missing of_node_put Julia Lawall
2019-01-13 18:48 ` Heiko Stuebner
2019-01-14 10:05 ` Daniel Vetter
2019-01-14 10:09 ` Heiko Stuebner
2019-01-13 8:47 ` [PATCH 4/4] drm/sun4i: backend: add missing of_node_puts Julia Lawall
2019-01-16 8:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547733638.4009.11.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Julia.Lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox