From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Manjunath Hadli <manjunath.hadli@ti.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Thaissa Falbo <thaissa.falbo@gmail.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Leo Sperling <leosperling97@gmail.com>,
sayli karnik <karniksayli1995@gmail.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: media: davinci_vpfe: unlock on error in vpfe_reqbufs()
Date: Tue, 22 Nov 2016 21:39:44 +0000 [thread overview]
Message-ID: <1552231.W5T0VxdTBZ@avalon> (raw)
In-Reply-To: <20161118113024.GA3150@mwanda>
Hi Dan,
Thank you for the patch.
On Friday 18 Nov 2016 14:30:24 Dan Carpenter wrote:
> We should unlock before returning this error code in vpfe_reqbufs().
>
> Fixes: 622897da67b3 ("[media] davinci: vpfe: add v4l2 video driver support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree. I will send a pull request for v4.11.
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> b/drivers/staging/media/davinci_vpfe/vpfe_video.c index c34bf46..353f3a8
> 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> @@ -1362,7 +1362,7 @@ static int vpfe_reqbufs(struct file *file, void *priv,
> ret = vb2_queue_init(q);
> if (ret) {
> v4l2_err(&vpfe_dev->v4l2_dev, "vb2_queue_init() failed\n");
> - return ret;
> + goto unlock_out;
> }
>
> fh->io_allowed = 1;
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-11-22 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 11:30 [patch] Staging: media: davinci_vpfe: unlock on error in vpfe_reqbufs() Dan Carpenter
2016-11-22 21:39 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552231.W5T0VxdTBZ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dan.carpenter@oracle.com \
--cc=hans.verkuil@cisco.com \
--cc=karniksayli1995@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=leosperling97@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=thaissa.falbo@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox