Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations

Michel Dänzer
2017-05-11T02:40:15Z

On 10/05/17 08:30 PM, Christian König wrote:
> Am 10.05.2017 um 02:23 schrieb Michel Dänzer:
>> On 03/05/17 09:46 PM, Christian König wrote:
>>> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring:
>>>> From: Markus Elfring <elfring@users.sourceforge.net>
>>>> Date: Tue, 2 May 2017 22:00:02 +0200
>>>>
>>>> Three update suggestions were taken into account
>>>> from static source code analysis.
>>>>
>>>> Markus Elfring (3):
>>>> Use seq_putc() in radeon_sa_bo_dump_debug_info()
>>>> Use seq_puts() in radeon_debugfs_pm_info()
>>>> Use seq_puts() in r100_debugfs_cp_csq_fifo()
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>> Based on
>> https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html
>> and followups, I'm afraid we'll have to make sure Markus' patches have
>> been tested adequately before applying them.
>
> I can't judge the background of that decision, but at least those tree
> patches for radeon looked trivial to me.

Which is part of the issue, see also
https://lists.freedesktop.org/archives/dri-devel/2017-May/140694.html
and other posts in that thread.

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer