From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 23 Sep 2016 11:49:17 +0000 Subject: Re: GPU-DRM-TTM: Fine-tuning for several function implementations Message-Id: <160f8c46-3601-aca9-cccc-054531cf16a8@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <4d34446f-05ad-c3ce-5d33-8fb4f25af25c@users.sourceforge.net> <05418fb1-ad66-aba3-bd8c-f6b684a83279@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: Julia Lawall , Daniel Vetter , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Emil Velikov > Calling the label "unlock" instead of "out" is arguable a little better, Thanks that you can follow a renaming for this direction in principle. > but nothing I would call a major improvement either. This was not my intention for such an use case. I am proposing some small software updates according to such a design pattern. > So that is a clear NAK to all those patches. Do you reject also update steps like the following then? * drm/ttm: Use kmalloc_array() in two (or four?) functions" * drm/ttm: Less function calls in ttm_dma_pool_init() after error detection * Would you like to improve the usage of the variables "n" and "t" in the function "ttm_dma_pool_init" any further as Joe Perches suggested it? >> 2. How do you think about to add a single space character before any label? > > Bad as well. Why would anybody want to do this? Do you find another software evolution interesting according to a recent commit? "docs: Remove space-before-label guidance from CodingStyle" https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?idyc70c304b0b443429b2a0019518532c5162817a Regards, Markus