Re: [PATCH net-next] hinic3: Fix NULL vs IS_ERR() check in hinic3_alloc_rxqs_res()

Vadim Fedorenko
2025-09-18T12:57:52Z

On 18/09/2025 10:45, Dan Carpenter wrote:
> The page_pool_create() function never returns NULL, it returns
> error pointers. Update the check to match.
>
> Fixes: 73f37a7e1993 ("hinic3: Queue pair resource initialization")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
> index 6cfe3bdd8ee5..16c00c3bb1ed 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
> @@ -414,7 +414,7 @@ int hinic3_alloc_rxqs_res(struct net_device *netdev, u16 num_rq,
> pp_params.dma_dir = DMA_FROM_DEVICE;
> pp_params.max_len = PAGE_SIZE;
> rqres->page_pool = page_pool_create(&pp_params);
> - if (!rqres->page_pool) {
> + if (IS_ERR(rqres->page_pool)) {
> netdev_err(netdev, "Failed to create rxq%d page pool\n",
> idx);
> goto err_free_cqe;

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>