* [PATCH net-next] dibs: Check correct variable in dibs_init()
@ 2025-09-24 14:21 Dan Carpenter
2025-09-24 16:49 ` Alexandra Winter
2025-09-26 22:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-09-24 14:21 UTC (permalink / raw)
To: Julian Ruess
Cc: Alexandra Winter, Paolo Abeni, netdev, linux-kernel,
kernel-janitors
There is a typo in this code. It should check "dibs_class" instead of
"&dibs_class". Remove the &.
Fixes: 804737349813 ("dibs: Create class dibs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/dibs/dibs_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
index 5425238d5a42..0374f8350ff7 100644
--- a/drivers/dibs/dibs_main.c
+++ b/drivers/dibs/dibs_main.c
@@ -258,8 +258,8 @@ static int __init dibs_init(void)
max_client = 0;
dibs_class = class_create("dibs");
- if (IS_ERR(&dibs_class))
- return PTR_ERR(&dibs_class);
+ if (IS_ERR(dibs_class))
+ return PTR_ERR(dibs_class);
rc = dibs_loopback_init();
if (rc)
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] dibs: Check correct variable in dibs_init()
2025-09-24 14:21 [PATCH net-next] dibs: Check correct variable in dibs_init() Dan Carpenter
@ 2025-09-24 16:49 ` Alexandra Winter
2025-09-26 22:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Alexandra Winter @ 2025-09-24 16:49 UTC (permalink / raw)
To: Dan Carpenter, Julian Ruess
Cc: Paolo Abeni, netdev, linux-kernel, kernel-janitors
On 24.09.25 16:21, Dan Carpenter wrote:
> There is a typo in this code. It should check "dibs_class" instead of
> "&dibs_class". Remove the &.
>
> Fixes: 804737349813 ("dibs: Create class dibs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/dibs/dibs_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index 5425238d5a42..0374f8350ff7 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -258,8 +258,8 @@ static int __init dibs_init(void)
> max_client = 0;
>
> dibs_class = class_create("dibs");
> - if (IS_ERR(&dibs_class))
> - return PTR_ERR(&dibs_class);
> + if (IS_ERR(dibs_class))
> + return PTR_ERR(dibs_class);
>
> rc = dibs_loopback_init();
> if (rc)
oops, this has been wrong since the first RFC in february.
Great catch, thank you Dan.
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] dibs: Check correct variable in dibs_init()
2025-09-24 14:21 [PATCH net-next] dibs: Check correct variable in dibs_init() Dan Carpenter
2025-09-24 16:49 ` Alexandra Winter
@ 2025-09-26 22:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-26 22:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: julianr, wintera, pabeni, netdev, linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 24 Sep 2025 17:21:17 +0300 you wrote:
> There is a typo in this code. It should check "dibs_class" instead of
> "&dibs_class". Remove the &.
>
> Fixes: 804737349813 ("dibs: Create class dibs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/dibs/dibs_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next] dibs: Check correct variable in dibs_init()
https://git.kernel.org/netdev/net-next/c/231889d9b626
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-26 22:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-24 14:21 [PATCH net-next] dibs: Check correct variable in dibs_init() Dan Carpenter
2025-09-24 16:49 ` Alexandra Winter
2025-09-26 22:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox