From: Matthew Wilcox <willy@debian.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] Check return value in
Date: Sat, 03 Jan 2004 22:35:09 +0000 [thread overview]
Message-ID: <20040103223509.GP6982@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040103132946.GE21909@eugeneteo.net>
On Sat, Jan 03, 2004 at 09:30:27PM +0800, Eugene Teo wrote:
> http://www.anomalistic.org/patches/mca-check-ret-mca_attach_bus-fix-2.6.1-rc1-mm1.patch
>
> diff -Naur -X /home/amnesia/w/dontdiff 2.6.1-rc1-mm1/arch/i386/kernel/mca.c 2.6.1-rc1-mm1-fix/arch/i386/kernel/mca.c
> --- 2.6.1-rc1-mm1/arch/i386/kernel/mca.c 2003-12-18 10:59:16.000000000 +0800
> +++ 2.6.1-rc1-mm1-fix/arch/i386/kernel/mca.c 2004-01-03 20:47:04.000000000 +0800
> @@ -35,6 +35,9 @@
> *
> * Alfred Arnold & David Weinehall August 23rd, 2000
> * - Added support for Planar POS-registers
> + *
> + * Eugene Teo January 3rd, 2004
> + * - Check the return value of mca_attach_bus
> */
>
> #include <linux/module.h>
> @@ -270,6 +273,8 @@
>
> /* All MCA systems have at least a primary bus */
> bus = mca_attach_bus(MCA_PRIMARY_BUS);
> + if (!bus)
> + goto out_nomem;
> bus->default_dma_mask = 0xffffffffLL;
> bus->f.mca_write_pos = mca_pc_write_pos;
> bus->f.mca_read_pos = mca_pc_read_pos;
This one looks right, but I don't think you should add your name to
the file. Two lines is not significant for copyright purposes.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-01-03 22:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-03 13:29 [Kernel-janitors] [PATCH] Check return value in mm/memory.c Eugene Teo
2004-01-03 13:30 ` [Kernel-janitors] [PATCH] Check return value in Eugene Teo
2004-01-03 13:31 ` [Kernel-janitors] [PATCH] Check return value in net/ipv4/ipmr.c Eugene Teo
2004-01-03 13:31 ` [Kernel-janitors] [PATCH] Check return value in fs/cifs/file.c Eugene Teo
2004-01-03 22:31 ` [Kernel-janitors] [PATCH] Check return value in mm/memory.c Matthew Wilcox
2004-01-03 22:35 ` Matthew Wilcox [this message]
2004-01-03 22:37 ` [Kernel-janitors] [PATCH] Check return value in net/ipv4/ipmr.c Matthew Wilcox
2004-01-04 2:39 ` [Kernel-janitors] [PATCH] Check return value in Eugene Teo
2004-01-04 2:45 ` [Kernel-janitors] [PATCH] Check return value in net/ipv4/ipmr.c Eugene Teo
2004-01-04 3:32 ` [Kernel-janitors] [PATCH] Check return value in mm/memory.c Eugene Teo
2004-01-04 7:58 ` [Kernel-janitors] [PATCH] Check return value in Eugene Teo
2004-01-04 8:07 ` Eugene Teo
2004-01-04 8:25 ` [Kernel-janitors] [PATCH] Check return value of __copy_from_user Eugene Teo
2004-01-04 8:47 ` [Kernel-janitors] [PATCH] Check return value of kernel_thread Eugene Teo
2004-01-08 0:45 ` [Kernel-janitors] [PATCH] Check return value in Randy.Dunlap
2004-01-08 12:18 ` Eugene Teo
2004-01-09 0:25 ` [Kernel-janitors] [PATCH] Check return value of __copy_from_user Randy.Dunlap
2004-01-09 0:54 ` Eugene Teo
2004-01-09 1:17 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040103223509.GP6982@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).