From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] Re: [PATCH] nbd: replace schedule_timeout()
Date: Tue, 20 Jul 2004 16:20:48 +0000 [thread overview]
Message-ID: <20040720162048.GA1983@us.ibm.com> (raw)
In-Reply-To: <20040720130244.GE27492@atrey.karlin.mff.cuni.cz>
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Tue, Jul 20, 2004 at 03:08:34PM +0200, Pavel Machek wrote:
> Hi!
>
> > >I'm not sure it makes sense.... so it will just spin once more? Exact
> > >timeout does not seem too critical here.
> >
> > So why not use HZ instead of 1000?
>
> Hm, using constant like 1000 probably is not good idea.
Well, I thought it would be better than adding a #define for the number
of milliseconds in one second. Also, any rounding conditions or what-not
are taken care of within msleep() by the call to msecs_to_jiffies().
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-07-20 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 13:02 [Kernel-janitors] Re: [PATCH] nbd: replace schedule_timeout() with Pavel Machek
2004-07-20 13:08 ` [Kernel-janitors] Re: [PATCH] nbd: replace schedule_timeout() Pavel Machek
2004-07-20 13:10 ` Felipe W Damasio
2004-07-20 16:17 ` Nishanth Aravamudan
2004-07-20 16:20 ` Nishanth Aravamudan [this message]
2004-07-20 16:23 ` [Kernel-janitors] Re: [PATCH] nbd: replace schedule_timeout() with Nishanth Aravamudan
2004-07-20 16:24 ` [Kernel-janitors] Re: [PATCH] nbd: replace schedule_timeout() Pavel Machek
2004-07-20 16:26 ` [Kernel-janitors] Re: [PATCH] nbd: replace schedule_timeout() with Pavel Machek
2004-07-20 16:35 ` [Kernel-janitors] Re: [PATCH] nbd: replace schedule_timeout() Nishanth Aravamudan
2004-07-20 16:36 ` Nishanth Aravamudan
2004-07-20 16:37 ` Pavel Machek
2004-07-20 16:42 ` Felipe W Damasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040720162048.GA1983@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).