From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH 2.6.9-rc2 3/4] sbus/bbc_i2c: replace
Date: Mon, 27 Sep 2004 17:26:56 +0000 [thread overview]
Message-ID: <20040927172656.GM1676@us.ibm.com> (raw)
In-Reply-To: <20040920235847.GF2270@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of
schedule_timeout() to guarantee the task delays as expected. Also use
set_current_state() instead of direct assignment of current->state.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc1-mm4-vanilla/drivers/sbus/char/bbc_i2c.c 2004-09-09 23:05:59.000000000 -0700
+++ 2.6.9-rc1-mm4/drivers/sbus/char/bbc_i2c.c 2004-09-10 15:42:35.000000000 -0700
@@ -189,13 +189,13 @@ static int wait_for_pin(struct bbc_i2c_b
while (limit-- > 0) {
u8 val;
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
*status = val = readb(bp->i2c_control_regs + 0);
if ((val & I2C_PCF_PIN) == 0) {
ret = 0;
break;
}
- schedule_timeout(HZ/4);
+ msleep_interruptible(250);
}
remove_wait_queue(&bp->wq, &wait);
bp->waiting = 0;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-09-27 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-20 23:58 [Kernel-janitors] [PATCH 2.6.9-rc2 3/4] mtd/cfi_cmdset_0002: Nishanth Aravamudan
2004-09-24 23:19 ` [Kernel-janitors] [PATCH 2.6.9-rc2 3/4] pci hotplug/pciehp: replace Nishanth Aravamudan
2004-09-27 17:26 ` Nishanth Aravamudan [this message]
2004-09-27 23:20 ` [Kernel-janitors] [PATCH 2.6.9-rc2 3/4] w1/w1_int: add Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927172656.GM1676@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).