From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] video/pxafb: reorder add_wait_queue() and
Date: Fri, 22 Oct 2004 23:45:43 +0000 [thread overview]
Message-ID: <20041022234542.GJ18906@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
Any comments would be, as always, appreciated.
-Nish
Description: Reorder set_current_state() and add_wait_queue(). There is
a chance that a signal could be missed in between the two functions
currently.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-bk7-vanilla/drivers/video/pxafb.c 2004-10-22 10:40:44.000000000 -0700
+++ 2.6.9-bk7/drivers/video/pxafb.c 2004-10-22 15:59:23.000000000 -0700
@@ -741,8 +741,8 @@ static void pxafb_disable_controller(str
DPRINTK("Disabling LCD controller\n");
- add_wait_queue(&fbi->ctrlr_wait, &wait);
set_current_state(TASK_UNINTERRUPTIBLE);
+ add_wait_queue(&fbi->ctrlr_wait, &wait);
LCSR = 0xffffffff; /* Clear LCD Status Register */
LCCR0 &= ~LCCR0_LDM; /* Enable LCD Disable Done Interrupt */
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-10-22 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 23:45 Nishanth Aravamudan [this message]
2004-10-24 14:10 ` [KJ] [PATCH] video/pxafb: reorder add_wait_queue() and maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022234542.GJ18906@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).