kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [PATCH 1/28] net/3c505: replace schedule_timeout() with
Date: Fri, 07 Jan 2005 21:38:21 +0000	[thread overview]
Message-ID: <20050107213821.GF2924@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On Thu, Jan 06, 2005 at 03:25:31PM -0800, Nishanth Aravamudan wrote:
> Hi,
> 
> Description: Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. There are no waitqueue events in the area, so an
> absolute sleep should be ok.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> --- 2.6.10-v/drivers/net/3c505.c	2004-12-24 13:35:49.000000000 -0800
> +++ 2.6.10/drivers/net/3c505.c	2005-01-04 14:57:49.000000000 -0800
> @@ -1327,8 +1327,7 @@ static int __init elp_sense(struct net_d
>  	if (orig_HSR & DIR) {
>  		/* If HCR.DIR is up, we pull it down. HSR.DIR should follow. */
>  		outb(0, dev->base_addr + PORT_CONTROL);
> -		set_current_state(TASK_UNINTERRUPTIBLE);
> -		schedule_timeout(30*HZ/100);
> +		msleep(300);
>  		if (inb_status(addr) & DIR) {
>  			if (elp_debug > 0)
>  				printk(notfound_msg, 2);
> @@ -1337,8 +1336,7 @@ static int __init elp_sense(struct net_d
>  	} else {
>  		/* If HCR.DIR is down, we pull it up. HSR.DIR should follow. */
>  		outb(DIR, dev->base_addr + PORT_CONTROL);
> -		set_current_state(TASK_UNINTERRUPTIBLE);
> -		schedule_timeout(30*HZ/100);
> +		msleep(300);
>  		if (!(inb_status(addr) & DIR)) {
>  			if (elp_debug > 0)
>  				printk(notfound_msg, 3);

Please ignore this patch, as there is already a more correct one in the
2.6.10-kj patchset. Sorry for the noise.

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2005-01-07 21:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050107213821.GF2924@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).